Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vision] Update bindings for Xcode 13.0 beta 1 #12460

Merged
merged 10 commits into from
Aug 26, 2021
Merged

[Vision] Update bindings for Xcode 13.0 beta 1 #12460

merged 10 commits into from
Aug 26, 2021

Conversation

rachelkang
Copy link
Contributor

No diffs for beta 2-5

Mac and TV monotouch tests currently failing

@rachelkang rachelkang added do-not-merge Do not merge this pull request note-highlight Worth calling out specifically in release notes labels Aug 17, 2021
@rachelkang rachelkang added this to the xcode13.0 milestone Aug 17, 2021
spouliot
spouliot suggested changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all new API should have availability attributes (I have not commented all of them)
or there should be a comment why it's not needed

src/vision.cs Outdated Show resolved Hide resolved
src/vision.cs Outdated Show resolved Hide resolved
src/vision.cs Outdated Show resolved Hide resolved
src/vision.cs Outdated Show resolved Hide resolved
src/vision.cs Show resolved Hide resolved
src/vision.cs Show resolved Hide resolved
src/vision.cs Outdated Show resolved Hide resolved
src/vision.cs Outdated Show resolved Hide resolved
src/vision.cs Outdated Show resolved Hide resolved
src/vision.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 100 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 2476 Passed: 2407 Inconclusive: 10 Failed: 1 Ignored: 68)
  • dont link/Mac Catalyst/Release [dotnet]: Failed (Test run crashed (exit code: 134).
    Tests run: 11 Passed: 6 Inconclusive: 0 Failed: 0 Ignored: 5)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge cb1bfd6 into 8f77e33

rolfbjarne
rolfbjarne requested changes Aug 18, 2021
View reviewed changes
src/Vision/VNUtils.cs Outdated Show resolved Hide resolved
tests/monotouch-test/Vision/VNUtilsTests.cs Outdated Show resolved Hide resolved
src/Vision/VNUtils.cs Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge cd3178c into 509b099

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

16 tests failed, 92 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: BuildFailure
  • xammac tests/Mac Modern/Release: BuildFailure
  • xammac tests/Mac Modern/Release (all optimizations): BuildFailure
  • monotouch-test/Mac [dotnet]/Debug [dotnet]: BuildFailure
  • monotouch-test/Mac Catalyst/Debug [dotnet]: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): BuildFailure
  • monotouch-test/tvOS - simulator/Debug: BuildFailure
  • monotouch-test/tvOS - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure
  • Xtro/Mac: Failed (Test run failed.)
  • introspection/iOS Unified 64-bits - simulator/Debug: Failed
  • introspection/tvOS - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 82eb501 into 4f5e2c5

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 107 tests passed.

Failed tests

  • xcframework-test/Mac Catalyst/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge a7ed18a into 28fc7bb

rolfbjarne
rolfbjarne approved these changes Aug 24, 2021
View reviewed changes
src/Vision/VNUtils.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 108 tests passed 🎉

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 18e088b into 3847fe0

@rachelkang rachelkang removed the do-not-merge Do not merge this pull request label Aug 26, 2021
@rachelkang rachelkang merged commit 5bab0da into xamarin:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
xcode13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rachelkang @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @spouliot @mandel-macaque